Resolve filter field names case-insensitively - #243
Merged
Merged
Conversation
Currently a QueryFields map only supports lowercase field names, because Finalize lowercases the field name before looking it up. Sort, GroupBy and RequiredFields instead match exactly, and silently drop anything else. With this change, mixed-case filter fields are now declarable. QueryFields.Resolve matches a field name exactly, then falls back to a case-insensitive match, and returns the name as declared. This applies to filter params as well as sort, group by, and fields. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a QueryFields map only supports lowercase field names, because Finalize lowercases the field name before looking it up. Sort, GroupBy and RequiredFields instead match exactly, and silently drop anything else. Query JSON also matches field names directly, so you are forced to only have lowercase keys in JSON filters.
With this change, mixed-case filter fields are now declarable.
QueryFields.Resolve matches a field name exactly, then falls back to a case-insensitive match, and returns the name as declared. This applies to filter params as well as sort, group by, and fields.